Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: remove immutable #182

Merged
merged 4 commits into from
Nov 9, 2023
Merged

feat!: remove immutable #182

merged 4 commits into from
Nov 9, 2023

Conversation

pyphilia
Copy link
Contributor

Remove immutable.

I still need to check it works with some apps.

@pyphilia pyphilia self-assigned this Oct 25, 2023
@pyphilia pyphilia marked this pull request as ready for review October 27, 2023 14:32
@pyphilia pyphilia requested a review from spaenleh October 27, 2023 14:32
@pyphilia pyphilia force-pushed the 181-remove-immutable branch from ee8789f to 157920c Compare November 2, 2023 17:10
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing ! You even removed the MUTATION_KEYS 🤩
Fantastic ! And we could get rid of jest-immutable-matchers 🎉

src/config/utils.ts Outdated Show resolved Hide resolved
src/hooks/postMessage.test.ts Outdated Show resolved Hide resolved
@pyphilia pyphilia merged commit ba43537 into main Nov 9, 2023
2 checks passed
@pyphilia pyphilia deleted the 181-remove-immutable branch November 9, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants