Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display heat loss #47

Merged
merged 1 commit into from
Nov 22, 2024
Merged

feat: display heat loss #47

merged 1 commit into from
Nov 22, 2024

Conversation

ReidyT
Copy link
Collaborator

@ReidyT ReidyT commented Nov 19, 2024

No description provided.

@ReidyT ReidyT self-assigned this Nov 19, 2024
@ReidyT ReidyT force-pushed the 46-display-heat-loss branch from 04bc091 to 62262b1 Compare November 19, 2024 14:34
@ReidyT ReidyT linked an issue Nov 21, 2024 that may be closed by this pull request
@ReidyT ReidyT requested review from pyphilia and spaenleh November 21, 2024 06:47
@ReidyT ReidyT marked this pull request as ready for review November 21, 2024 06:48
Copy link

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🧊
You might like to split a bit your FirstScene, it looks a bit big.

src/config/models.ts Outdated Show resolved Hide resolved
* feat(refactor): split the house into smaller components
* feat: compute the heat loss for each wall directly
* feat: improve the simulation informations UI
* feat: simplify the house and set it as a square
@ReidyT ReidyT force-pushed the 46-display-heat-loss branch from eaf7d18 to c8a7602 Compare November 22, 2024 12:45
@ReidyT ReidyT merged commit b1ebce1 into main Nov 22, 2024
3 checks passed
@ReidyT ReidyT deleted the 46-display-heat-loss branch November 22, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display the Heat Loss
3 participants