Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: import temperature and implement the simulation engine #36

Merged
merged 1 commit into from
Oct 30, 2024
Merged

feat: import temperature and implement the simulation engine #36

merged 1 commit into from
Oct 30, 2024

Conversation

ReidyT
Copy link
Collaborator

@ReidyT ReidyT commented Oct 25, 2024 •
edited
Loading

See #32 for a demo.

In this PR, I implemented a new iteration of the app by:

  • importing the temperatures from CSV file (it could be hourly or daily measurement)
  • implementing the mechanism to iterate over the temperatures (part of the simulation engine)
  • implementing the heat loss and electricity cost
  • changing the season according to the current period (range of dates)
  • implementing unit tests to test the logic using vitest (no cypress tests for now)

@ReidyT ReidyT self-assigned this Oct 25, 2024
@ReidyT ReidyT force-pushed the 32-import-temperature-implement-engine branch 2 times, most recently from 4eb4535 to 7219b3d Compare October 28, 2024 07:48
@ReidyT ReidyT linked an issue Oct 28, 2024 that may be closed by this pull request
Import temperatures and implement simulation engine #32
Closed
@ReidyT ReidyT force-pushed the 32-import-temperature-implement-engine branch 2 times, most recently from 3451646 to 5431cea Compare October 28, 2024 12:55
@ReidyT ReidyT marked this pull request as ready for review October 28, 2024 12:58
@ReidyT ReidyT requested review from spaenleh and pyphilia October 28, 2024 12:58
@ReidyT ReidyT changed the title feat: import temperature implement engine feat: import temperature and implement the simulation engine Oct 28, 2024
spaenleh
spaenleh approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good !
I made a quick review of the changes, I like that you put a lot of unit tests !

Great work !

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
pyphilia
pyphilia approved these changes Oct 29, 2024
View reviewed changes
Copy link

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks really well managed 👍

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/langs/en.json Show resolved Hide resolved
src/modules/scenes/FirstScene.tsx Show resolved Hide resolved
src/modules/scenes/FirstScene.tsx Show resolved Hide resolved
src/modules/scenes/FirstScene.tsx Show resolved Hide resolved
src/modules/scenes/FirstScene.tsx Show resolved Hide resolved
src/modules/scenes/FirstScene.tsx Show resolved Hide resolved
@ReidyT ReidyT mentioned this pull request Oct 30, 2024
Open
@ReidyT ReidyT force-pushed the 32-import-temperature-implement-engine branch from 6d328ae to 154535a Compare October 30, 2024 09:36
@ReidyT ReidyT merged commit b6d9af7 into main Oct 30, 2024
3 checks passed
@ReidyT ReidyT deleted the 32-import-temperature-implement-engine branch October 30, 2024 09:39
@github-actions github-actions bot mentioned this pull request Oct 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaenleh spaenleh spaenleh approved these changes

@pyphilia pyphilia pyphilia approved these changes

Assignees

@ReidyT ReidyT

Labels
un-released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Import temperatures and implement simulation engine
3 participants
@ReidyT @pyphilia @spaenleh