Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: apply new changes for typeorm #45

Merged
merged 13 commits into from
Jun 7, 2023
Merged

refactor: apply new changes for typeorm #45

merged 13 commits into from
Jun 7, 2023

Conversation

pyphilia
Copy link
Contributor

No description provided.

@pyphilia pyphilia requested review from swouf and spaenleh May 30, 2023 08:29
swouf
swouf requested changes May 30, 2023
View reviewed changes
Copy link
Contributor

@swouf swouf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! It gives me an example of what needs to be changed in an app to work with the refactor. I just have minor comments.

package.json Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
@swouf swouf self-assigned this May 30, 2023
@pyphilia pyphilia temporarily deployed to development June 7, 2023 13:12 — with GitHub Actions Inactive
@pyphilia pyphilia merged commit 79f8c6a into main Jun 7, 2023
@pyphilia pyphilia deleted the typeorm-from-main branch June 7, 2023 13:29
@github-actions github-actions bot mentioned this pull request Jun 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swouf swouf swouf requested changes

@spaenleh spaenleh Awaiting requested review from spaenleh

Assignees

@swouf swouf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pyphilia @swouf