Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: set gpt model version #214

Merged
merged 3 commits into from
May 7, 2024
Merged

feat: set gpt model version #214

merged 3 commits into from
May 7, 2024

Conversation

LinaYahya
Copy link
Contributor

@LinaYahya LinaYahya commented Apr 30, 2024 •
edited
Loading

closes #213

image
image

@LinaYahya LinaYahya self-assigned this Apr 30, 2024
@LinaYahya LinaYahya requested review from pyphilia and spaenleh April 30, 2024 09:37
pyphilia
pyphilia requested changes May 1, 2024
View reviewed changes
Copy link

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, I've left some concerns for the check, I think it makes sense to write tests to check the options work and also the case where chatbotPrompts is undefined or empty.

package.json Outdated Show resolved Hide resolved
src/langs/en.json Outdated Show resolved Hide resolved
src/modules/common/ChatbotPrompt.tsx Show resolved Hide resolved
src/modules/common/CommentThread.tsx Show resolved Hide resolved
spaenleh
spaenleh approved these changes May 1, 2024
View reviewed changes
src/modules/common/ChatbotPrompt.tsx Show resolved Hide resolved
src/modules/settings/ChatbotSettings.tsx Outdated Show resolved Hide resolved
@LinaYahya LinaYahya requested a review from pyphilia May 6, 2024 11:03
@spaenleh spaenleh force-pushed the 213-set-model-version branch from 61d0159 to 548e689 Compare May 7, 2024 09:02
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented May 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@spaenleh spaenleh merged commit 0869cb8 into main May 7, 2024
5 checks passed
@github-actions github-actions bot mentioned this pull request May 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaenleh spaenleh spaenleh approved these changes

@pyphilia pyphilia Awaiting requested review from pyphilia

Assignees

@LinaYahya LinaYahya

Labels
v1.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow to set model version
3 participants
@LinaYahya @pyphilia @spaenleh