feat: analytics view #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spaenleh
requested changes
Feb 28, 2024
There was a problem hiding this comment.
Looks good, just some comments I think should be addressed:
- We should not use
dangerouslySetInnerHTML, see my comment. We can also discuss in person for more detail - You have sometimes
AnalyticandsometimesAnalytics. Choose one, preferablyAnalytics` (with the s).
🏀
There was a problem hiding this comment.
What is the purpose of these changes exactly ?
pyphilia
requested changes
Feb 29, 2024
| @@ -11,5 +12,5 @@ body { | |||
|
|
|||
| #root { | |||
| height: 100%; | |||
| overflow: hidden; | |||
| overflow: auto; | |||
There was a problem hiding this comment.
Not sure about these changes, maybe let's look how it behaves in the development environment.
There was a problem hiding this comment.
the purpose of this change is to make sure that the table is controlling height and scroll,
this how it looks with current changes
and this is how it would be with the previous version
spaenleh
requested changes
Mar 1, 2024
spaenleh
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #83