Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Apps query client connection and save calculation action #82

Merged
merged 5 commits into from
Feb 27, 2024
Merged

feat: Apps query client connection and save calculation action #82

merged 5 commits into from
Feb 27, 2024

Conversation

LinaYahya
Copy link
Contributor

@LinaYahya LinaYahya commented Feb 16, 2024 •
edited
Loading

  • connect calculator with apps query client
  • save actions on equality
  • setup cypress api to enable mock api

@LinaYahya LinaYahya changed the title 80 api setup feat: Apps query client connection and save calculation action Feb 16, 2024
@LinaYahya LinaYahya marked this pull request as ready for review February 19, 2024 10:04
@LinaYahya LinaYahya self-assigned this Feb 19, 2024
@LinaYahya LinaYahya linked an issue Feb 19, 2024 that may be closed by this pull request
Connect to graasp API #80
Closed
pyphilia
pyphilia requested changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've discussed some changes, and I've added minor suggestions. But it looks really good overall! 🦄

cypress/fixtures/mockItem.ts Outdated Show resolved Hide resolved
src/components/common/Calculator.tsx Outdated Show resolved Hide resolved
src/components/common/Calculator.tsx Outdated Show resolved Hide resolved
src/config/constants.ts Outdated Show resolved Hide resolved
src/mocks/db.ts Show resolved Hide resolved
@LinaYahya LinaYahya requested a review from pyphilia February 21, 2024 09:49
pyphilia
pyphilia approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🐇

cypress/fixtures/members.ts Outdated Show resolved Hide resolved
cypress/support/commands.ts Outdated Show resolved Hide resolved
@LinaYahya LinaYahya merged commit 9490126 into main Feb 27, 2024
2 checks passed
@github-actions github-actions bot mentioned this pull request Feb 27, 2024
Merged
@spaenleh spaenleh deleted the 80-api-setup branch July 29, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyphilia pyphilia pyphilia approved these changes

@spaenleh spaenleh Awaiting requested review from spaenleh

Assignees

@LinaYahya LinaYahya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Connect to graasp API
2 participants
@LinaYahya @pyphilia