Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: move member welcome card in settings #875

Merged
merged 2 commits into from
Feb 12, 2025
Merged

feat: move member welcome card in settings #875

merged 2 commits into from
Feb 12, 2025

Conversation

pyphilia
Copy link
Contributor

close #873

@pyphilia pyphilia requested a review from spaenleh February 11, 2025 11:06
@pyphilia pyphilia self-assigned this Feb 11, 2025
spaenleh
spaenleh reviewed Feb 11, 2025
View reviewed changes
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, I think you will have to change the path for the test in the homePage.cy.ts as they target the now moved avatar upload feature.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@spaenleh spaenleh merged commit 389bb88 into main Feb 12, 2025
5 checks passed
@spaenleh spaenleh deleted the 873-avatar-settings branch February 12, 2025 07:08
@graasper graasper mentioned this pull request Feb 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaenleh spaenleh spaenleh approved these changes

Assignees

@pyphilia pyphilia

Labels
v2.20.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add avatar of home in settings
2 participants
@pyphilia @spaenleh