Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roadmap: Merging all Client apps into a single project #380

Open
7 of 17 tasks
spaenleh opened this issue Oct 16, 2024 · 1 comment
Open
7 of 17 tasks

Roadmap: Merging all Client apps into a single project #380

spaenleh opened this issue Oct 16, 2024 · 1 comment
Assignees

Comments

@spaenleh
Copy link
Member

spaenleh commented Oct 16, 2024

We would like to reduce the spread of the project to have to maintain and work on a single app for the client.

Project preparation:

Migration to `@tanstack/react-router:

Use @tanstack/react-router instead of react-router-dom as it allows to split on routes and managing routes with typesafety is awesome.

Making the project single origin

We want to host the project on a single domain, to:

  • simplify cookie management and make it more secure, no more (.graasp.org cookies)

  • remove the need for CORS

  • streamline the devlopment and usage of common layouts in a single project

  • Backend should be reachable at graasp.org/api

    • Infra: update load-balancer config to serve /api requests to the backend
    • remove the need for API_HOST in query-client, just use relative routes
  • migrate player here

  • migrate analytics here

  • migrate builder here

  • builder.graasp.org, auth.graasp.org, player.graasp.org should redirect to the path equivalents using the load-balancer

  • library should be served on a subpath too

  • We should be able to remove the CORS for the core endpoints since all the trafic should be from the graasp.org domain.

@spaenleh spaenleh self-assigned this Oct 16, 2024
@pyphilia
Copy link
Contributor

What's the difference between "use @tanstack/react-router" and "migrate account to tanstack router". Are you referring to the code, then to the deployment?

Otherwise seems like a good plan!

@spaenleh spaenleh pinned this issue Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants