Skip to content

Commit

Permalink
Refactor some comments and error messages
Browse files Browse the repository at this point in the history
  • Loading branch information
dnestoro committed Jan 23, 2024
1 parent 02eb069 commit ee840ab
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions docs/src/docs/asciidoc/gradle-plugin.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -363,7 +363,7 @@ NOTE: This version of the plugin defaults to the using the metadata repository i

=== Configuring the metadata repository

Metadata repository is enabled by default. Support can be disabled explicitly:
Metadata repository support is enabled by default. Support can be disabled explicitly:

.Disabling the metadata repository
[source, groovy, role="multi-language-sample"]
Expand Down Expand Up @@ -403,7 +403,7 @@ include::../snippets/gradle/groovy/build.gradle[tags=specify-metadata-repository
include::../snippets/gradle/kotlin/build.gradle.kts[tags=specify-metadata-repository-file]
----

For each library included in the native image, the plugin will automatically search for GraalVM reachability metadata in the repository.
For each library included in the native image, the plugin will automatically search for GraalVM image build configuration metadata in the repository.
In some cases, you may need to exclude a particular module from the search.
This can be done by adding it to the exclude list:

Expand Down
2 changes: 1 addition & 1 deletion docs/src/docs/asciidoc/maven-plugin.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -658,7 +658,7 @@ include::../../../../samples/native-config-integration/pom.xml[tag=metadata-loca
----
<1> The local path can point to an _exploded_ directory, or to a compressed ZIP file.

For each library included in the native image, the plugin will automatically search for GraalVM reachability metadata in the repository that was released together with the plugin.
For each library included in the native image, the plugin will automatically search for GraalVM image build configuration metadata in the repository that was released together with the plugin.
In case you want to use another version of the metadata use:

.Choosing a version for the metadata repository
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ class MetadataRepositoryFunctionalTest extends AbstractGraalVMMavenFunctionalTes

then:
buildFailed
outputContains " Cannot pull GraalVM reachability metadata repository either from the one specified in the configuration or the default one"
outputContains "Cannot pull GraalVM reachability metadata repository either from the one specified in the configuration or the default one"
}

void "it can exclude dependencies"() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ private Path getDefaultRepo(Path destinationRoot) {
String metadataUrl = String.format(METADATA_REPO_URL_TEMPLATE, VersionInfo.METADATA_REPO_VERSION);
try {
targetUrl = new URI(metadataUrl).toURL();
// TODO investigate if the following line is necessary
// TODO investigate if the following line is necessary (Issue: https://github.com/graalvm/native-build-tools/issues/560)
metadataRepositoryConfiguration.setUrl(targetUrl);
} catch (URISyntaxException | MalformedURLException e) {
throw new RuntimeException(e);
Expand Down Expand Up @@ -199,7 +199,7 @@ private Path getRepo(Path destinationRoot) {
String metadataUrl = String.format(METADATA_REPO_URL_TEMPLATE, version);
try {
targetUrl = new URI(metadataUrl).toURL();
// TODO investigate if the following line is necessary
// TODO investigate if the following line is necessary (Issue: https://github.com/graalvm/native-build-tools/issues/560)
metadataRepositoryConfiguration.setUrl(targetUrl);
} catch (URISyntaxException | MalformedURLException e) {
throw new RuntimeException(e);
Expand Down

0 comments on commit ee840ab

Please sign in to comment.