Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hook into OutgoingMessage.prototype.end #5

Closed
Tracked by #3
gr2m opened this issue Dec 22, 2021 · 1 comment · Fixed by #6
Closed
Tracked by #3

Hook into OutgoingMessage.prototype.end #5

gr2m opened this issue Dec 22, 2021 · 1 comment · Fixed by #6
Labels
released

Comments

@gr2m
Copy link
Owner

gr2m commented Dec 22, 2021 •
edited
Loading

(the parent of ClientRequest) that according to https://github.com/nodejs/node/blob/113133badbe3c2f40f61eac733006207e06b9cc2/lib/_http_outgoing.js#L833 seems to call an internal method directly (not going through write). Wouldn't that miss output?
—moll/node-mitm#76 (comment)
This was referenced Dec 22, 2021
Closed
Merged
@gr2m gr2m closed this as completed in #6 Dec 22, 2021
@github-actions
Copy link

🎉 This issue has been resolved in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Hook into OutgoingMessage.prototype.end gr2m/node-http-recorder
1 participant
@gr2m