Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create a pull request also on change hidden files #262

Merged
merged 2 commits into from
Nov 29, 2020

Conversation

bgpat
Copy link
Contributor

@bgpat bgpat commented Nov 19, 2020

If the hidden file or directory (e.g., .github .env) are changed, this action behaves as No local changes without path option.
In the default shell, * ignores hidden files.

before

The hidden files are skipped to create a pull request.

  • .github/workflows/test.yml => ignored
  • .env => ignored
  • path/to/.env => not ignored
  • foo => not ignored

after

On modifying any file, creates a pull request.

@gr2m
Copy link
Owner

gr2m commented Nov 19, 2020

@bgpat
Copy link
Contributor Author

bgpat commented Nov 20, 2020

@gr2m Okay, should I add a test as a new PR?

@gr2m
Copy link
Owner

gr2m commented Nov 20, 2020

no need, you can add to the existing pull requset

@bgpat
Copy link
Contributor Author

bgpat commented Nov 28, 2020

@gr2m I added the test, please review.

Copy link
Owner

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gr2m gr2m merged commit 7ecde07 into gr2m:master Nov 29, 2020
@github-actions
Copy link
Contributor

🎉 This PR is included in version 1.3.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants