Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evaluate possible crashes on RPC callbacks #223

Open
gr0vity-dev opened this issue Jan 10, 2023 · 0 comments
Open

Evaluate possible crashes on RPC callbacks #223

gr0vity-dev opened this issue Jan 10, 2023 · 0 comments

Comments

@gr0vity-dev
Copy link
Owner

2021-09-16T22:32:50Z zhyatt
When we check for it's possible the async handler already executed. If there was an error it may have set and will be called twice. Consider this pattern: First do all pre-checks, and only afterwards call the async handlers:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gr0vity-dev