Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It is possible to assign one tag mutipletimes to one bookmark #1167

Open
pinkavaj opened this issue Nov 8, 2022 · 1 comment
Open

It is possible to assign one tag mutipletimes to one bookmark #1167

pinkavaj opened this issue Nov 8, 2022 · 1 comment
Labels

Comments

@pinkavaj
Copy link
Contributor

pinkavaj commented Nov 8, 2022

Right now it is possible to assign the same tag multiple times to the same bookmark. The workflow is a bit obscure, but with many tags in the list not impossible.

Steps to reproduce:

  • Open "Bookmarks" tab
  • Select "Add new bookmark"
  • In the window click "add new bookmark" and set a name
  • Do the same again and again with the same name ...

Similar approach can be used for editing tag for existing bookmark

@vladisslav2011
Copy link
Contributor

I can't reproduce observed behavior. This does not assign multiple tags. This just creates multiple bookmarks at the same frequency with the same (or different) name and the same or different tags. I think that's a bug too, but a different bug (I've fixed this in my dev branch, but I have not opened a PR yet... Or the fix is buried inside of multi_vfo branch, I don't remember.)

There are at least 2 different solutions:

  1. Avoid creating multiple bookmark at the same frequency. Fail silently or with a message.
  2. Update the existing bookmark with a new name and tag list (my fix follows this way).

@argilo argilo added the bug label Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants