Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.1.0 is a breaking change #78

Closed
iest opened this issue Nov 10, 2015 · 5 comments
Closed

1.1.0 is a breaking change #78

iest opened this issue Nov 10, 2015 · 5 comments

Comments

@iest
Copy link

iest commented Nov 10, 2015

Renaming Util to Helper (on 0eee2ec) and then eventually to dateUtils (on f555948) is a breaking change according to semver.

The latest version should be at least 2.0.0.

@gpbl
Copy link
Owner

gpbl commented Nov 10, 2015

Uhm... did the change break something documented in the API? Because semver applies to the public API, while Utils was an internal module.

@iest
Copy link
Author

iest commented Nov 10, 2015

Depends what you mean as a "public API" — your Selectable day example uses the "internal module" for isSameDay. I imagine a lot of your users (myself included) use those utilities on their own components.

If your examples use private APIs that aren't included in your definition of semver, I suggest you remove them or label them as such?

Don't get me wrong — this module is awesome and it's saved me a lot of time — I'm just logging an issue that others might well run into.

@gpbl
Copy link
Owner

gpbl commented Nov 11, 2015

👍 The examples are right, they have been rewritten for v1.1. Starting from this version, those API are public and documented: from now breaking changes to those utilities will bump a major version.

I'm sorry for the confusion, there've been some delay with the new website...

@iest
Copy link
Author

iest commented Nov 11, 2015

Awesome! Glad to hear it ✨

@gpbl
Copy link
Owner

gpbl commented Dec 4, 2015

Closing this now that we are on v1.2.0! Thanks for reminding me about the dangers of semver :) I hope I won't break things anymore 🚶

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants