Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: adjust paddings in centred align screen and bulleted list #204

Merged
merged 2 commits into from
Feb 27, 2025
Merged

refactor: adjust paddings in centred align screen and bulleted list #204

merged 2 commits into from
Feb 27, 2025
+21 −7

Conversation

emanuel-gds
Copy link
Contributor

@emanuel-gds emanuel-gds commented Feb 25, 2025 •
edited
Loading

DCMAW-11691: Update bulleted list component

Ticket

  • Add horizontal padding to bulleted list
  • Add horizontal padding to centred aligned screen elements
  • Remove outer padding from centred aligned screen

Evidence of the change

Checklist

Before creating the pull request

  • Commit messages that conform to conventional commit messages.
  • Ran the app locally ensuring it builds.
  • Tests pass locally.
  • Pull request has a clear title with a short description about the feature or update.
  • Created a draft pull request if it's not ready for review.

Before the CODEOWNERS review the pull request

  • Complete all Acceptance Criteria within Jira ticket.
  • Self-review code.
  • Successfully run changes on a testing device.
  • Complete automated Testing:
    • Unit Tests.
    • Integration Tests.
    • Instrumentation / Emulator Tests.
  • Review Accessibility considerations.
  • Handle PR comments.

Before merging the pull request

@ThomasIent ThomasIent force-pushed the main branch 2 times, most recently from a303979 to 9dd7201 Compare February 26, 2025 15:19
@obinns-dd obinns-dd force-pushed the feat/DCMAW-11691-adjust-layout branch from 63040a3 to 37ae436 Compare February 27, 2025 10:12
@obinns-dd obinns-dd force-pushed the feat/DCMAW-11691-adjust-layout branch from 37ae436 to 23a5498 Compare February 27, 2025 10:17
@emanuel-gds emanuel-gds force-pushed the feat/DCMAW-11691-adjust-layout branch from 23a5498 to 56f33e7 Compare February 27, 2025 15:34
@emanuel-gds emanuel-gds marked this pull request as ready for review February 27, 2025 17:28
@emanuel-gds emanuel-gds requested review from a team as code owners February 27, 2025 17:28
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@emanuel-gds emanuel-gds merged commit 3801f2a into main Feb 27, 2025
4 checks passed
@emanuel-gds emanuel-gds deleted the feat/DCMAW-11691-adjust-layout branch February 27, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonnyandrew jonnyandrew jonnyandrew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emanuel-gds @jonnyandrew