Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config Not Editable for Variants without a Config Form #260

Open
JonKo314 opened this issue May 16, 2024 · 1 comment
Open

Config Not Editable for Variants without a Config Form #260

JonKo314 opened this issue May 16, 2024 · 1 comment

Comments

@JonKo314
Copy link
Collaborator

The Fractional Go demo just uses the default config for Fractional Go and doesn't allow changing it. This is probably because Fractional Go doesn't have a config form yet.

  • Option 1: Add config forms for all variants
  • Option 2: Allow editing of raw JSON config for demos
@benjaminpjones
Copy link
Collaborator

I'd recommend a hybrid approach: introduce a JSONConfigForm, and use it by default.

I think we should also strive for real config forms for all variants (1), but that can be a pain for prototyping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants