Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk edit metadata number sort increment #1727

Closed
5 tasks done
calcul0n opened this issue Oct 6, 2024 · 2 comments
Closed
5 tasks done

Bulk edit metadata number sort increment #1727

calcul0n opened this issue Oct 6, 2024 · 2 comments
Labels
bug Something isn't working released WebUI Need works in the WebUI

Comments

@calcul0n
Copy link

calcul0n commented Oct 6, 2024

Steps to reproduce

  1. Select several books and click bulk edit metadata.
  2. Change the value in any of the sort number fields.
  3. Click the 'increment all by 1' icon.

Expected behavior

The number in the edited sort field should have been numerically incremented by 1.

Actual behavior

The number 1 has now been appended to each of the fields edited rather than +1 being numerically added, it seems the value here is being treated as a string and not a number.

Logs

No response

Komga version

v1.14.0

Operating system

Windows 11

Installation method

from download.komga.org

Other details

No response

Acknowledgements

  • I have searched the existing issues (open AND closed) and this is a new ticket, NOT a duplicate or related to another open issue.
  • I have written a short but informative title.
  • I have checked the FAQ.
  • I have updated the app to the latest version.
  • I will fill out all of the requested information in this form.
@calcul0n calcul0n added the triage label Oct 6, 2024
@gotson
Copy link
Owner

gotson commented Oct 7, 2024

sounds like a Javascript quirk, everything is typed as number

@gotson gotson added bug Something isn't working WebUI Need works in the WebUI and removed triage labels Oct 7, 2024
@gotson gotson closed this as completed in e1b9296 Oct 7, 2024
Copy link
Contributor

🎉 This issue has been resolved in 1.14.1 (Release Notes)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working released WebUI Need works in the WebUI
Projects
None yet
Development

No branches or pull requests

2 participants