Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround MAX_PACKAGE_NOTIFICATIONS #359

Open
powellnorma opened this issue Jun 25, 2024 · 3 comments
Open

Workaround MAX_PACKAGE_NOTIFICATIONS #359

powellnorma opened this issue Jun 25, 2024 · 3 comments
Labels
question Further information is requested

Comments

@powellnorma
Copy link

Let's say I have a script that sends me a "warning" every 30s or so. Now I leave the room for ~30min. In that time, the script already has send > MAX_PACKAGE_NOTIFICATIONS (~= 50) notifications, so I never get notified, and miss the crucial thing the script wanted to remind me of.

A workaround is mentioned e.g. here: https://medium.com/mindorks/the-notification-limit-per-app-in-android-94af69a6862c

Basically we'd have to remember past notifications send, e.g. in a double-ended queue, and once that queue is >= MAX_PACKAGE_NOTIFICATIONS, cancel the oldest notifications.

Is anyone aware of a simpler workaround? What are you thoughts on this?

@jmattheis
Copy link
Member

Why do you receive warnings every 30s? You could also argue the other way around. When canceling the oldest notification you could lose a critical alert.

@jmattheis jmattheis added the question Further information is requested label Jun 25, 2024
@powellnorma
Copy link
Author

Why do you receive warnings every 30s?

It's so that I don't miss it - The notification contains a link to a custom web app where I can turn the notification off (or delay it).

When canceling the oldest notification you could lose a critical alert.

Fair - how about we make this feature opt-in?
It could also be on per channel/App basis - Some Apps can get their notification cancelled (once the limit is reached), others not

@jmattheis
Copy link
Member

how about we make this feature opt-in?

I don't want to support every use-case in Gotify to keep it simple and maintainable. This feature doesn't seem like something many users need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Development

No branches or pull requests

2 participants