Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Death from above counts as damage even if you hit nothing #13

Open
gothos-folly opened this issue Nov 3, 2015 · 6 comments
Open

Death from above counts as damage even if you hit nothing #13

gothos-folly opened this issue Nov 3, 2015 · 6 comments
Labels

Comments

@gothos-folly
Copy link
Owner

It looks like dealing 225 damage to yourself.

Perhaps I should ignore all damage dealt to oneself.

@Gl0
Copy link

Gl0 commented Nov 9, 2015

DFA is not critical, due to small numbers, but gunner's self-destruct is significant, doing 10M damage to turrel and robot. Note that you need to check owner, simple attacker=target will not work, because one spawned npc (robot) can hit another (turrel). Send pull request with fix. Not sure, that it is the best way, as usual.

@gothos-folly
Copy link
Owner Author

What annoys me most with DFA is that I don't know what this message is supposed to say. Where does this 225 come from?

@Gl0
Copy link

Gl0 commented Nov 10, 2015

lunyx found, that DFA packet with 225 damage have different SkillResultFlag (4). Seems that it is not damage, but some effect strength.
Here's the code for sending effect animation packet from java server emulator:
target.broadcastPacket(Damage.getInstance(attacker, target, template.getDamageId(), getPower(), false, false, Damage.EFFECT))

@Roukanken42
Copy link

Only thing I can think of is RE regen - afterall Dfa is doing that as direct effect, not as side effect of hitting. The number does seem a bit high (would expect 150-200, but it's still in realm of possibility).

@Gl0
Copy link

Gl0 commented Nov 10, 2015

It can be bitwise. Or have any other logic. RE regen effect is the most possible value of this packet.

@Roukanken42
Copy link

Actually DFA does infact restore exactly 225 RE. So it's probably that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants