Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for OpenH264 #2

Closed
alexbbb opened this issue Sep 27, 2015 · 3 comments
Closed

Add support for OpenH264 #2

alexbbb opened this issue Sep 27, 2015 · 3 comments
Labels
enhancement
Milestone
1.0.0

Comments

@alexbbb
Copy link
Contributor

alexbbb commented Sep 27, 2015

Enhance the compilation process by adding OpenH264 for every target arch.
Follow the instructions here: http://trac.pjsip.org/repos/ticket/1758 and then make sure to copy the generated .so files in the final build folder for every arch. Also check if the latest OpenH264 release works. Actually, version 1.4.0 is out, but the ticket on PJSIP trac suggests to use 1.0.0.
@alexbbb alexbbb added this to the 1.0.0 milestone Sep 27, 2015
alexbbb added a commit that referenced this issue Sep 29, 2015
@alexbbb
#2 added support for OpenH264. Currently it builds for armeabi, armea…
8e1d681 
…bi-v7a and x86. x86_64 and arm64-v8a are in progress..
alexbbb added a commit that referenced this issue Sep 29, 2015
@alexbbb
#2 set NDKLEVEL to at least 21 to be able to compile OpenH264 for x86…
e393463 
…_64 and arm64-v8a
alexbbb added a commit that referenced this issue Sep 30, 2015
@alexbbb
#2 downgraded OpenH264 to version 1.0.0, because PJSip 2.4.5 can't co…
c18a4a1 
…mpile against versions of OpenH264 newer than 1.0.0 at the moment. A patch was necessary to be able to compile it with Android NDK 21 (Lollipop). With the current scripts, OpenH264 1.4.0 compiled also for x86_64 and arm64-v8a, but OpenH264 1.0.0 fails the build with those architectures. At the moment PJSip compiles with OpenH264 support for: armeabi, armeabi-v7a and x86
@alexbbb
Copy link
Contributor Author

alexbbb commented Oct 1, 2015

Support for archs armeabi, armeabi-v7a and x86 is complete.
Compilation errors occurs for x86_64 and arm64-v8a

@alexbbb
Copy link
Contributor Author

alexbbb commented Oct 1, 2015

Support for x86_64 and arm64-v8a will be added in a future release

@alexbbb alexbbb closed this as completed Oct 1, 2015
@alexbbb alexbbb mentioned this issue Dec 23, 2015
Closed
@gotev gotev mentioned this issue Mar 16, 2016
Closed
@gotev
Copy link
Contributor

gotev commented Mar 16, 2016

OpenH264 1.0.0 does not support 64 bit architectures, as can be seen from here: https://github.com/cisco/openh264/releases. Newer releases have added that support, but they are not compatible with pjsip 2.4.5 out of the box.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@alexbbb @gotev