Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix path pattern in documentation pipeline #919

Merged
merged 1 commit into from
May 21, 2024

Conversation

dklimpel
Copy link
Contributor

@dklimpel dklimpel commented May 18, 2024

Checklist
  • make test-all (UNIX) passes. CI will also test this
  • unit and/or integration tests are included (if applicable)
  • documentation is changed or added (if applicable)

Description of change

IMHO there is an error in the path pattern in the documentation pipeline.
The pipeline should run at any changes in docs folder. But the PR #917 and #918 show that is not the case.
But there should be a preview, especially for changes to the requirements.txt.

I was also able to reproduce this in a test.

Docs:

After a merge #917 and #918 should be rebased.

@dklimpel dklimpel requested a review from aelsabbahy as a code owner May 18, 2024 19:23
@aelsabbahy aelsabbahy merged commit 9729bc2 into goss-org:master May 21, 2024
1 check passed
@dklimpel dklimpel deleted the path_patter_doc_ci branch May 21, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants