Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDE json schema: skip is not mandatory for process tests #874

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

rasschaert
Copy link
Contributor

Checklist

Description of change

The json schema used by IDEs claims that "skip" is a mandatory property of a process test.

image

Adding the skip property causes goss to fail with this error message:

Error: Invalid Attribute for Process:caddy: skip

I can only presume that at some point the skip attribute was supported and required, but was later removed. It seems the json spec file wasn't modified with this change.

Copy link
Member

@aelsabbahy aelsabbahy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, skip was never mandatory, the json schema was wrong.

@aelsabbahy aelsabbahy merged commit e73553f into goss-org:master Feb 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants