diff --git a/.changeset/curvy-readers-drive.md b/.changeset/curvy-readers-drive.md new file mode 100644 index 00000000000..0e4cd19bba4 --- /dev/null +++ b/.changeset/curvy-readers-drive.md @@ -0,0 +1,9 @@ +--- +'@arch-ui/fields': major +'@keystonejs/fields-markdown': patch +'@keystonejs/fields-mongoid': patch +--- + +Cleaned up FieldDescription usage. The `` component no longer accepts children and requires a `text` prop: + +`Hello World` => `` diff --git a/packages/arch/packages/fields/src/index.js b/packages/arch/packages/fields/src/index.js index 0057f309657..2c6ff1a35bb 100644 --- a/packages/arch/packages/fields/src/index.js +++ b/packages/arch/packages/fields/src/index.js @@ -36,16 +36,19 @@ export const FieldLabel = props => { ); }; -export const FieldDescription = props => ( -

-); +export const FieldDescription = ({ text, ...props }) => + text ? ( +

+ {text} +

+ ) : null; export const FieldInput = props => (
- {field.config.adminDoc && {field.config.adminDoc}} +
{ return ( - {field.config.adminDoc && {field.config.adminDoc}} + { return ( - {field.config.adminDoc && {field.config.adminDoc}} + - {field.config.adminDoc && {field.config.adminDoc}} + {!isEmpty && imagePath ? ( diff --git a/packages/fields/src/types/Color/views/Field.js b/packages/fields/src/types/Color/views/Field.js index e2fedc1ee45..74481751806 100644 --- a/packages/fields/src/types/Color/views/Field.js +++ b/packages/fields/src/types/Color/views/Field.js @@ -61,7 +61,7 @@ const ColorField = ({ field, value: serverValue, errors, onChange }) => { return ( - {field.config.adminDoc && {field.config.adminDoc}} + { return ( - {field.config.adminDoc && {field.config.adminDoc}} + diff --git a/packages/fields/src/types/Decimal/views/Field.js b/packages/fields/src/types/Decimal/views/Field.js index a0fb7d3f54b..791cbc083d9 100644 --- a/packages/fields/src/types/Decimal/views/Field.js +++ b/packages/fields/src/types/Decimal/views/Field.js @@ -37,7 +37,7 @@ const TextField = ({ onChange, autoFocus, field, value, errors }) => { return ( - {field.config.adminDoc && {field.config.adminDoc}} + {symbol && {symbol}} - {field.config.adminDoc && {field.config.adminDoc}} + {file ? ( diff --git a/packages/fields/src/types/Float/views/Field.js b/packages/fields/src/types/Float/views/Field.js index 02d652abda3..856ef1e198b 100644 --- a/packages/fields/src/types/Float/views/Field.js +++ b/packages/fields/src/types/Float/views/Field.js @@ -17,7 +17,7 @@ const TextField = ({ onChange, autoFocus, field, value, errors }) => { return ( - {field.config.adminDoc && {field.config.adminDoc}} + { return ( - {field.config.adminDoc && {field.config.adminDoc}} + - {field.config.adminDoc && {field.config.adminDoc}} + - {field.config.adminDoc && {field.config.adminDoc}} + {isEditing ? ( diff --git a/packages/fields/src/types/Relationship/views/Field.js b/packages/fields/src/types/Relationship/views/Field.js index 7d08ff0b099..112f24cc799 100644 --- a/packages/fields/src/types/Relationship/views/Field.js +++ b/packages/fields/src/types/Relationship/views/Field.js @@ -187,7 +187,7 @@ const RelationshipField = ({ return ( - {field.config.adminDoc && {field.config.adminDoc}} +
- {field.config.adminDoc && {field.config.adminDoc}} +
- {field.config.adminDoc && {field.config.adminDoc}} + return ( - {field.config.adminDoc && {field.config.adminDoc}} + - {field.config.adminDoc && {field.config.adminDoc}} + { return ( - {field.config.adminDoc && {field.config.adminDoc}} + );