Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question May I open an PR to refactor or organize the test code in decoder_test.go? #220

Closed
1 task done
lll-lll-lll-lll opened this issue Sep 14, 2024 · 1 comment
Closed
1 task done
Labels

Comments

@lll-lll-lll-lll
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

No response

Expected Behavior

No response

Steps To Reproduce

No response

Anything else?

May I open an PR to refactor or organize the test code in decoder_test.go?

Why

There is test code from over 10 years ago, and when adding new tests, I find it difficult to check whether similar test code has already been written.

I think this is somewhat unavoidable, but if there are tests that can be consolidated, perhaps we could do so. What do you all think?

@jaitaiwan
Copy link
Member

Go for it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants