Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rustfmt.tomlfile #228

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

jquesada2016
Copy link
Contributor

Currently, the project does not have a rustfmt.toml, causing inconsistant formatting for users who contribute with a non-default global rustfmt.toml file.

Copy link

cla-bot bot commented Nov 2, 2023

We require contributors to sign our Contributor License Agreement, and we don't have yours on file. In order for us to review and merge your code, please send a signing request to [email protected] and add your github handle to contributors list.

Copy link

linear bot commented Nov 2, 2023

GDL-374 Add `rustfmt.toml`

Currently, the project does not have a rustfmt.toml, causing inconsistant formatting for users who contribute with a non-default global rustfmt.toml file.

@iluminn
Copy link
Contributor

iluminn commented Nov 3, 2023

Can we

  1. keep the line width at 100
  2. wait until the export pr is merged and any other backend prs going now

@jquesada2016
Copy link
Contributor Author

Sure. Setting the width to 100 will remove all merge conflicts, since rustfmt won't touch anything. I set it to 80 to avoid line wrapping/scrolling.

This reverts commit ddbc1a8.
Copy link

cla-bot bot commented Nov 3, 2023

We require contributors to sign our Contributor License Agreement, and we don't have yours on file. In order for us to review and merge your code, please send a signing request to [email protected] and add your github handle to contributors list.

Copy link

cla-bot bot commented Nov 3, 2023

We require contributors to sign our Contributor License Agreement, and we don't have yours on file. In order for us to review and merge your code, please send a signing request to [email protected] and add your github handle to contributors list.

@jquesada2016
Copy link
Contributor Author

I really think max_width should be set to 80, otherwise there can be a lot of vertical scrolling or line wrapping, in this case for me, but also for users who work with more than one window open at a time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants