-
-
Notifications
You must be signed in to change notification settings - Fork 779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add missing rest props to backdrop component #1895
Merged
gorhom
merged 1 commit into
gorhom:master
from
hraschan:backdrop-accessibility-rest-props
Jul 28, 2024
Merged
fix: add missing rest props to backdrop component #1895
gorhom
merged 1 commit into
gorhom:master
from
hraschan:backdrop-accessibility-rest-props
Jul 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gorhom
approved these changes
Jul 28, 2024
@gorhom Thanks for the quick merge. Can you tell when this gets released to npm? |
This was referenced Sep 8, 2024
This was referenced Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide enough information so that others can review your pull request:
Motivation
Explain the motivation for making this change. What existing problem does the pull request solve?
This PR is in order to fis issue #1892. Please review my changes.
The rest props didn't get added to the view. Therefore the "importantForAccessibility" is not available to the component.