Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twitter Ad Injection #6

Closed
jeo1 opened this issue Apr 9, 2015 · 20 comments
Closed

Twitter Ad Injection #6

jeo1 opened this issue Apr 9, 2015 · 20 comments

Comments

@jeo1
Copy link

jeo1 commented Apr 9, 2015

On https://twitter.com/jacquesgallant Twitter inserted ads under the title "Suggested by Twitter".
The ad only appeared when I was logged into Twitter.
It did not show up 100% of the time.
twitterad

Using:
-uBlock 0.9.3.0
-Chrome 41.0.2272.118 m
-Windows 7

Disable all other extensions and ad still showed up

Thank you very much.

@gorhill
Copy link
Owner

gorhill commented Apr 9, 2015

I don't remember ever seeing these sponsored entries on Twitter.

What are your selected filter lists? Custom filters? Dynamic filtering rules?

When this occurs, I would like you to open the dev console for the page, I want to see if there are errors reported on the page.

@jeo1
Copy link
Author

jeo1 commented Apr 9, 2015

I only started seeing these ads a day or two ago.
It just occurred to me that I have been using chrome with sandboxie and because of that the filter updates get deleted each time I clear the sand box.
So there is a good chance this is just another problems caused by an idiot user.

I have been using:
uBlock filters‎
uBlock filters – Privacy‎
EasyList
Peter Lowe's Ad server list
EasyPrivacy
Malware Domain List
Malware domains
Malware domains (long-lived)

I have no custom rules in place.

@gorhill
Copy link
Owner

gorhill commented Apr 9, 2015

EasyList is the one taking care of the sponsored tweets.

If you use the element picker to selected that tweet entry, what are the suggested filters? I would like to see if they are as they should be, i.e. there is one matching the proper filter in EasyList.

@gorhill
Copy link
Owner

gorhill commented Apr 9, 2015

By the way, I can't get that "Sponsored by Twitter" entry, even without uBlock. I do get sponsored stuff -- marked with an orange label -- but I can't get that big one in there. Maybe because of some kind of targeting? (hence why it would happen only when you are logged in).

When I get a sponsored entry (with uBlock disabled), there is never a big "Sponsored by Twitter" header at the top, it's more discreet.

@Betsy25
Copy link

Betsy25 commented Apr 9, 2015

I do get them (different, personalized? content) when having cosmetic filtering disabled, but with consmetic filtering enabled, the Easylist takes care of them over here.

@gorhill
Copy link
Owner

gorhill commented Apr 9, 2015

@Betsy25 I can get sponsored/promoted entries with uBlock off, but I never saw one with a big header "Suggested by Twitter".

@Betsy25
Copy link

Betsy25 commented Apr 9, 2015

@jeo1 If you see one again, click the eye-dropper icon in the uBlock₀ popup, and try to highlight the whole rectangle of the sponsored item (not part of it, try to highlight it completely, takes a bit of pinpointing) before clicking, and copy/paste the rule it gives you.

@gorhill Well as soon as I disable cosmetic filtering, I can get one (most of the time):

capture

@gorhill
Copy link
Owner

gorhill commented Apr 9, 2015

@jeo1 Did you turn off the badge which shows the blocked count? Normally when loading a twitter page, it should already show a couple of blocked requests.

@jeo1
Copy link
Author

jeo1 commented Apr 9, 2015

Still waiting to see more these ads.
@Betsy25 will do.
@gorhill nope have not turn it off.

@jeo1
Copy link
Author

jeo1 commented Apr 9, 2015

twitterad
I was using a different computer, same filters as before, every thing is up to date.

###stream-item-tweet-565314759743270912 > .js-expansion-container.expansion-container > .opened-tweet.is-loaded.ProfileTweet--promoted.leadgen-card-forward.has-cards.js-send-impression-cookie.is-promoted.ProfileTweet--high.js-actionable-tweet.js-stream-tweet.js-tweet.u-textBreak.ProfileTweet

Cosmetic filters Click, Ctrl-click
##.opened-tweet.is-loaded.ProfileTweet--promoted.leadgen-card-forward.has-cards.js-send-impression-cookie.is-promoted.ProfileTweet--high.js-actionable-tweet.js-stream-tweet.js-tweet.u-textBreak.ProfileTweet
##.js-expansion-container.expansion-container
###stream-item-tweet-565314759743270912
##.Grid-cell
##.Grid:nth-of-type(5)
##.GridTimeline-items
##.GridTimeline
##.u-lg-size2of3.Grid-cell
##.Grid--withGutter.Grid
##.u-lg-size3of4.u-size2of3.Grid-cell
##.Grid--withGutter.Grid
##.u-cf.AppContent-main
##.AppContainer
###page-container
###page-outer
###doc

edit: Same style of ad showed up when I disable the other extensions.

@jeo1
Copy link
Author

jeo1 commented Apr 9, 2015

Just purge all filter caches, then updated them. Not seeing the ad.

@gorhill
Copy link
Owner

gorhill commented Apr 9, 2015

Still, I checked all the cosmetic filters you pasted above, and none of them was a hit on EasyList. EasyList contains these Twitter-specific cosmetic filters:

twitter.com##.promoted-account
twitter.com##.promoted-trend
twitter.com##.promoted-tweet
twitter.com##.promotion
twitter.com##.stream-item[data-item-type="tweet"][data-item-id*=":"]
twitter.com##li[label="promoted"]

And none in your report is a match. On my side I get:

[...]
###timeline
###page-container
###page-outer
###doc

And yours is:

##.AppContainer
###page-container
###page-outer
###doc

I get ###timeline, you get .AppContainer.

Did you give access to some apps/hooks in your twitter account?

@jeo1
Copy link
Author

jeo1 commented Apr 9, 2015

TweetDeck and Twitter for Android.

@jeo1
Copy link
Author

jeo1 commented Apr 9, 2015

Revoked both of them, but I would be very surprised if either were the responsible.

@gorhill
Copy link
Owner

gorhill commented Apr 9, 2015

There might be a theme to these ads? The two I see in your pics are related to computer security.

@gorhill
Copy link
Owner

gorhill commented Apr 9, 2015

@jeo1
Copy link
Author

jeo1 commented Apr 9, 2015

I think your right, the ads are targeted (I follow a number of people who are linked to information security). I wonder if Twitter is testing a new ad system.

@jeo1
Copy link
Author

jeo1 commented Apr 9, 2015

That exact ad was first one of this sort I saw.

@gorhill
Copy link
Owner

gorhill commented Apr 9, 2015

Ok, I see EasyList was updated today with a filter which matches one of the selector you listed above:

https://hg.adblockplus.org/easylist/rev/6a769b9e7dfe

.is-promoted

So case closed?

@jeo1
Copy link
Author

jeo1 commented Apr 9, 2015

I think so, sorry for the trouble.

@jeo1 jeo1 closed this as completed Apr 9, 2015
pmrowla pushed a commit to pmrowla/uBlock that referenced this issue Feb 7, 2017
tl;dr use keyboard to press trust, not mouse
ryanbr pushed a commit to ryanbr/uBlock that referenced this issue Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants