Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Allow browser specific rules #1215

Closed
tcptomato opened this issue Jan 12, 2016 · 4 comments
Closed

[Request] Allow browser specific rules #1215

tcptomato opened this issue Jan 12, 2016 · 4 comments
Labels

Comments

@tcptomato
Copy link

Unfortunately not all functionality is implemented on all browsers ( script:contains would be a perfect example). I think it would make sense to allow for browser specific rules, like

example.com##script:contains(ads)$firefox
example.com$inline-script,chrome

@ghost
Copy link

ghost commented Jan 12, 2016

I had a similar idea here: #1178 (comment)
Yours seems better though.

@tcptomato
Copy link
Author

@gorhill What would be your recommendation to use in a filter list to block things efficiently on both browsers? Using a coarse filter (for chrome) on firefox ( where you can use a finer one) is not the most efficient thing in the world.

@gorhill
Copy link
Owner

gorhill commented Jan 12, 2016

Blocking all inline scripts is easy using dynamic filtering pane. The wholesale blocking of inline scripting by default should be left to the user given how this can cripple a site.

@tcptomato
Copy link
Author

I'm sorry, I think I should have explained the use case better. It's to remove some annoying anti-adblocker scripts on specific sites, not something that should be done by default. The option here would be not use the site at all, or use it in a crippled fashion. (if using the inline-script option). Unfortunately this filter could be replaced with a better one on firefox, but at the moment it can't be done in an automatic fashion using a single list for both browsers.

And I don't want to impose myself, but could you please give me a feedback on my pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants