fix: Ask user to confirm generated passphrase before invocing pinentry #3035
+10
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to avoid users not seeing their generated password if using e.g. pinentry curses UI. Fixes gopasspw#3030 Signed-off-by: Dominik Schulz <[email protected]>
AnomalRoil
reviewed
Jan 13, 2025
This way generating the ID might fail, but at least we don't have to do ugly API changes to figure out a clean way to delete an ID file after a failed setup attempt. Signed-off-by: Dominik Schulz <[email protected]>
AnomalRoil
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to avoid users not seeing their generated password if using e.g. pinentry curses UI.
Fixes #3030