Graphic of GraphicOverlay does not have click listener, could we build one in and use it later for some use-cases?

[XinyueZ]

https://github.com/firebase/quickstart-android/blob/master/mlkit/app/src/main/java/com/google/firebase/samples/apps/mlkit/common/GraphicOverlay.java

[samtstern]

@XinyueZ what use cases? Do you mean improving the sample?

[XinyueZ]

yes, because, sometimes user can click graphic and search something, for example, barcode or url search on internet.

[samtstern]

That makes sense, are you asking how to do this in your own code or do you just want to see it added to the sample to benefit others?

[XinyueZ]

Actually, I think a lot of developers including me use the GraphicOverlay in their apps, my idea is that the official sample of you could import the click-listener to Graphic.
I have done in my local fork, however, I am not sure whether it is allowed to create one PR. How is your mind @samtstern ? or not? 👹

[samtstern]

@XinyueZ if you want to send a PR I am happy to review it!

[XinyueZ]

OK, I will try .

[XinyueZ]

@samtstern just want to confirm, the common package are including all java, should PR or new features in the common must be java or it is OK for kotlin ?

[samtstern]

@XinyueZ sorry I never responded here! Let's keep common to all java so that the Java app can have all Java dependencies.