Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release aarch64-apple-darwin binary #829

Merged

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation

/kind feature

/kind hotfix

What this PR does / Why we need it:

We started getting more Mac M1 and M2 users, and it's while it's possible to run the x86_64-apple-darwin version, and we're not sure if it's causing network issues.

Since the prerequisites of doing this got release in https://github.com/joseluisq/rust-linux-darwin-builder/releases/tag/v1.65.0 this is relatively easy to do now.

Which issue(s) this PR fixes:

Closes #610

Special notes for your reviewer:

N/A

We started getting more Mac M1 and M2 users, and it's while it's
possible to run the x86_64-apple-darwin version, and we're not sure if
it's causing network issues.

Since the prerequisites of doing this got release in
https://github.com/joseluisq/rust-linux-darwin-builder/releases/tag/v1.65.0
this is relatively easy to do now.

Closes googleforgames#610
@markmandel markmandel added kind/feature New feature or request area/build-tools Development tooling. labels Oct 18, 2023
@XAMPPRocky XAMPPRocky enabled auto-merge (squash) October 18, 2023 21:59
@XAMPPRocky XAMPPRocky merged commit bda6e65 into googleforgames:main Oct 18, 2023
3 checks passed
@quilkin-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 5540edfd-3149-4c14-b468-8b3c47e6e6ec

The following development images have been built, and will exist for the next 30 days:

To build this version:

git fetch [email protected]:googleforgames/quilkin.git pull/829/head:pr_829 && git checkout pr_829
cargo build

@markmandel markmandel deleted the build/aarch64-apple-darwin branch October 18, 2023 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build-tools Development tooling. kind/feature New feature or request size/xs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release macos/arm64 binary
3 participants