Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use reflectors for Agones provider API #532

Closed
XAMPPRocky opened this issue May 10, 2022 · 1 comment
Closed

Use reflectors for Agones provider API #532

XAMPPRocky opened this issue May 10, 2022 · 1 comment
Assignees
@rezvaneh
Labels
area/performance Anything to do with Quilkin being slow, or making it go faster. area/xds Related to Envoy xDS help wanted Extra attention is needed kind/feature New feature or request

Comments

@XAMPPRocky
Copy link
Collaborator

Currently the Agones provider always directly accesses kubernete's API, to reduce the number of accesses we should use kube::runtime::reflector to cache values instead, and update the version when a new version is created.
@XAMPPRocky XAMPPRocky added kind/feature New feature or request help wanted Extra attention is needed area/performance Anything to do with Quilkin being slow, or making it go faster. area/xds Related to Envoy xDS labels May 10, 2022
@XAMPPRocky
Copy link
Collaborator Author

Implemented in #527

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rezvaneh rezvaneh

Labels
area/performance Anything to do with Quilkin being slow, or making it go faster. area/xds Related to Envoy xDS help wanted Extra attention is needed kind/feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@XAMPPRocky @rezvaneh