Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt cobra #380

Open
yuryu opened this issue Aug 29, 2022 · 0 comments
Open

Adopt cobra #380

yuryu opened this issue Aug 29, 2022 · 0 comments

Comments

@yuryu
Copy link
Member

yuryu commented Aug 29, 2022

Cobra seems like a popular package used for CLI applications.

Pros:

  • Single command for all features (like server and collector)
  • Extensible
  • Go community seems pretty familiar with the syntax
  • Reuse the same code for options and configurations handling

Cons:

  • Breaks compatibility because we'll remove collector

After cobra, it'd look like:

  • open_saves serve to run the server
  • open_saves collect to run the garbage collector

We could also add commands like restart, stop, reload, etc in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant