Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis Username is ignored #1759

Open
scrayos opened this issue Apr 22, 2024 · 0 comments
Open

Redis Username is ignored #1759

scrayos opened this issue Apr 22, 2024 · 0 comments
Labels
kind/bug Something isn't working

Comments

@scrayos
Copy link

scrayos commented Apr 22, 2024

What happened:
Even though the username for the redis connection can be configured and is considered within the code, it is not actually used. It always assumes the user default. I enabled usePassword and supplied a working username-password pair, but it only started working when I supplied the default user password (with the non-default username). This leads me to believe, that the username is completely ignored and only the password is actually important.

What you expected to happen:
The username should be considered. Otherwise only the default user can be used, making any kind of ACL configuration redundant.

How to reproduce it (as minimally and precisely as possible):

  1. Use a Redis Database with ACL enabled and a user default and apple, both with their own distinct passwords.
  2. Adjust the matchmaker configuration and create the corresponding secret (with the password of user apple)
  3. Create a ticket and get io.grpc.StatusException: UNAVAILABLE: CreateTicket, id: coj74uis0ooc738qg5lg, failed to connect to redis: WRONGPASS invalid username-password pair or user is disabled.

Config:

redis:
  hostname: redis-master.redis
  port: 6379
  user: apple
  usePassword: true
  passwordPath: /app/config/redis/password

Anything else we need to know?:
This is most probably a bug within any of the dependencies (redigo), as the construction of the redis string looks fine: https://github.com/googleforgames/open-match/blob/v1.8.1/internal/statestore/redis.go#L235

Output of kubectl version:
Server Version: v1.27.11

Cloud Provider/Platform (AKS, GKE, Minikube etc.):
Hetzner Cloud

Open Match Release Version:
1.8.1

Install Method(yaml/helm):
YAML with Kustomize

@scrayos scrayos added the kind/bug Something isn't working label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant