Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flaky test in testing/e2e/cluster_test.go #1592

Open
joeholley opened this issue Aug 31, 2023 · 0 comments
Open

flaky test in testing/e2e/cluster_test.go #1592

joeholley opened this issue Aug 31, 2023 · 0 comments
Labels
kind/bug Something isn't working

Comments

@joeholley
Copy link
Collaborator

What happened:
flaky test was removed from 1.7 -> 1.8 in testing/e2e/cluster_test.go. Diff them to see it: release-1.7...release-1.8

This failure is caused by updating the open match config - this test just checks the config against another copy of the config... I'm not sure this actually has any value. If the intention is to make sure no unintentional changes get committed to the config file, that should be handled by source control approvals, not be a test inside the application code. Either way, the latest bitnami chart lets k8s generate the endpoint name, which then gets populated to the configmap (it's random). If we do want this as an application-level test, it needs to be reworked to ignore that param in the config (or some other solution). Open to discussion.

How to reproduce it (as minimally and precisely as possible):
Run the e2e tests job in the cloudbuild config at commit af4d6ce

@joeholley joeholley added the kind/bug Something isn't working label Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant