Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non-deterministic interpolation error #1146

Closed
cmyr opened this issue Nov 28, 2024 · 2 comments · Fixed by #1150
Closed

non-deterministic interpolation error #1146

cmyr opened this issue Nov 28, 2024 · 2 comments · Fixed by #1150
Assignees
Labels
bug Something isn't working

Comments

@cmyr
Copy link
Member

cmyr commented Nov 28, 2024

there's sime jitter on crater runs lately involving one particular font, which fails to compile some portion of the time.

repro with,

python resources/scripts/ttx_diff.py 'https://github.com/ThomasJockin/readexpro#sources/ReadexPro.glyphs'.

(it took me four tries to get a failure, but maybe you're luckier than I am?)

@cmyr
Copy link
Member Author

cmyr commented Nov 28, 2024

Okay, so I think I've figured this out; it's a race condition related to nested components. When converting components to contours we need to make sure to perform this operation in order, i.e. if glyph A has component B has component C we need to make sure we convert B before A.

@cmyr cmyr added the bug Something isn't working label Nov 28, 2024
@cmyr cmyr self-assigned this Nov 28, 2024
@rsheeter
Copy link
Contributor

rsheeter commented Dec 2, 2024

IIUC we shouldn't need ttx_diff, just run $ cargo run -- ~/.fontc_crater_cache/ThomasJockin/readexpro/sources/ReadexPro.glyphs over and over. Locally I'm seeing this fail on the order of 50% of the time on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants