Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how to increase the room size and is it possible to use webrtc for multiple users at a time ? #72

Open
ghost opened this issue Apr 3, 2018 · 1 comment

Comments

@ghost
Copy link

ghost commented Apr 3, 2018

I tried to implement conference call but it is not possible , can you help us to increase the room size of foo

@nitobuendia
Copy link
Contributor

@sarathkumar654

The codelab is designed as a showcase of only two connections.

If you want a code focused on multiple connections, perhaps you want to have a look at the webrtc/samles where they have an example of multiple peer connections.

As for adapting the codelab:

Assuming you are on step-06, the lines of code that relates to the limit of users per room are these:

index.js [36-49]:

    if (numClients === 0) {
      socket.join(room);
      log('Client ID ' + socket.id + ' created room ' + room);
      socket.emit('created', room, socket.id);
    } else if (numClients === 1) {
      log('Client ID ' + socket.id + ' joined room ' + room);
      // io.sockets.in(room).emit('join', room);
      socket.join(room);
      socket.emit('joined', room, socket.id);
      io.sockets.in(room).emit('ready', room);
      socket.broadcast.emit('ready', room);
    } else { // max two clients
      socket.emit('full', room);
    }

Here, you can change the number of peers that you want to interact together:
} else if (numClients === 1) {

If you want to remove the limit, you can simplify the if statement.

    if (numClients === 0) {
      socket.join(room);
      log('Client ID ' + socket.id + ' created room ' + room);
      socket.emit('created', room, socket.id);
    } else {
      log('Client ID ' + socket.id + ' joined room ' + room);
      // io.sockets.in(room).emit('join', room);
      socket.join(room);
      socket.emit('joined', room, socket.id);
      io.sockets.in(room).emit('ready', room);
      socket.broadcast.emit('ready', room);
    }

If it does not work, perhaps other changes are required. In this case, I recommend you that you complete the codelab to learn the basics; then, you can base your efforts on the multiple peers sample from the other repository.

I hope this helps.

Cheers,
Nito

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant