From ef4544b3c96b12eec571f8fd20a12cfdff4f4402 Mon Sep 17 00:00:00 2001 From: Tomo Suzuki Date: Fri, 15 Jul 2022 15:51:15 -0400 Subject: [PATCH 1/3] ci: gapic auto repositories not to have special codeowners --- synthtool/gcp/templates/java_library/.github/CODEOWNERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/synthtool/gcp/templates/java_library/.github/CODEOWNERS b/synthtool/gcp/templates/java_library/.github/CODEOWNERS index f6961cac2..ee71f89f2 100644 --- a/synthtool/gcp/templates/java_library/.github/CODEOWNERS +++ b/synthtool/gcp/templates/java_library/.github/CODEOWNERS @@ -6,7 +6,9 @@ {% if 'codeowner_team' in metadata['repo'] %} # The {{ metadata['repo']['codeowner_team'] }} is the default owner for changes in this repo * @googleapis/yoshi-java {{ metadata['repo']['codeowner_team'] }} +{% if 'library_type' in metadata['repo'] and metadata['repo']['library_type'] != 'GAPIC_AUTO' %} **/*.java {{ metadata['repo']['codeowner_team'] }} +{% endif %} {% else %} * @googleapis/yoshi-java {% endif %} From 4d9473f73fcbc050d36bdecac801f80098567fa9 Mon Sep 17 00:00:00 2001 From: Tomo Suzuki Date: Fri, 15 Jul 2022 23:28:45 -0400 Subject: [PATCH 2/3] ci: adding comment for codeowners for handwritten libs --- synthtool/gcp/templates/java_library/.github/CODEOWNERS | 1 + 1 file changed, 1 insertion(+) diff --git a/synthtool/gcp/templates/java_library/.github/CODEOWNERS b/synthtool/gcp/templates/java_library/.github/CODEOWNERS index ee71f89f2..37403088c 100644 --- a/synthtool/gcp/templates/java_library/.github/CODEOWNERS +++ b/synthtool/gcp/templates/java_library/.github/CODEOWNERS @@ -7,6 +7,7 @@ # The {{ metadata['repo']['codeowner_team'] }} is the default owner for changes in this repo * @googleapis/yoshi-java {{ metadata['repo']['codeowner_team'] }} {% if 'library_type' in metadata['repo'] and metadata['repo']['library_type'] != 'GAPIC_AUTO' %} +# for handwritten libraries, keep codeowner_team in .repo-metadata.json as owner **/*.java {{ metadata['repo']['codeowner_team'] }} {% endif %} {% else %} From 45ec21a5184a111a5db5ef03897e87e722e91223 Mon Sep 17 00:00:00 2001 From: Tomo Suzuki Date: Mon, 18 Jul 2022 16:36:56 -0400 Subject: [PATCH 3/3] ci: reviewer for samples java-samples-reviewers --- .../gcp/templates/java_library/.github/sync-repo-settings.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/synthtool/gcp/templates/java_library/.github/sync-repo-settings.yaml b/synthtool/gcp/templates/java_library/.github/sync-repo-settings.yaml index a5a31c42b..72acb9d8f 100644 --- a/synthtool/gcp/templates/java_library/.github/sync-repo-settings.yaml +++ b/synthtool/gcp/templates/java_library/.github/sync-repo-settings.yaml @@ -58,3 +58,6 @@ permissionRules: permission: admin - team: yoshi-java permission: push +- team: java-samples-reviewers + permission: push +