Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we make the response event for streaming requests optional? #7

Closed
callmehiphop opened this issue Jul 21, 2016 · 2 comments
Closed

Comments

@callmehiphop
Copy link

Relates to googleapis/google-cloud-node#1443

I'm using grpc as a transport and it does not emit any kind of event to let me know if the initial request was successful or not, instead it waits until all data has been received. If I use retry-request in combination of grpc, then I run into an error where either all the data buffers in memory or the stream reaches capacity and can no longer be written to.

@stephenplusplus
Copy link
Contributor

stephenplusplus commented Apr 21, 2017

@callmehiphop going to close, I don't think there's anything to do here-- I might forget exactly what we're asking for, but if we solved it upstream, let's assume that was an edge case that's no longer edgy.

@callmehiphop
Copy link
Author

Yeah, I think we just changed the way we used gRPC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants