-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BazelBot hasn't created a change for a C# generator update #5039
Comments
The change also occurred on the preview branch, but that doesn't have a commit on the preview branch of googleapis-gen either. |
Bazel bot failed to generate all the csharp targets. Therefore, no changes were committed. I see this error repeated throughout the bazel bot log:
Assigning this bug back to Jon for advice. |
My guess is that this was caused by updating the .NET SDK from 6.0.402 to 6.0.408 in the Bazel rules (in this commit). This issue may or may not be related. In order to unblock the pipeline during the UK day, I'll revert just the Bazel part of that commit and do a new release (and update WORKSPACE to refer to it). I'll then reach out to @SurferJeffAtGoogle to find a way to reproduce this myself, so I can work on a fix without having to go via doing a release each time. |
Reverting to 6.0.402 has fixed the build - we now have the changes propagated to googleapis-gen. I'll work on diagnosing why 6.0.408 fails. |
An attempt to reproduce this: First start bash in a new container with the docker image:
Now do the simple bits of a build, which should exercise the problematic part:
... but that succeeds :( Next, try bazelisk instead (in a fresh container), e.g.
... that succeeds as well. So I'm stuck as to how to reproduce this... |
Update: I now have a docker image (from this commit) which fails in Cloud Build, but works in a local Docker build. Curiouser and curiouser. Will try to reduce it further... |
googleapis/googleapis commit 70eaf0dbe updates the C# GAPIC generator to v1.4.14.
On a local Linux box, this correctly generates new code - the simplest way of telling being that snippets are now generated in a namespace of GoogleCSharpSnippets.
However, there isn't a corresponding commit for googleapis-gen.
Changes I'd expect from this update:
The text was updated successfully, but these errors were encountered: