fix: Allow an empty value for --label #1397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chingor13
approved these changes
Apr 15, 2022
|
Shoot, this won't quite work because |
product-auto-label
bot
added
size: s
chingor13
approved these changes
Apr 15, 2022
chingor13
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Apr 15, 2022
🤖 I have created a release *beep* *boop* --- ## [13.12.0](v13.11.1...v13.12.0) (2022-04-15) ### Features * allow configuring `release-search-depth` and `commit-search-depth` ([#1396](#1396)) ([102d650](102d650)), closes [#1394](#1394) ### Bug Fixes * Allow an empty value for --label ([#1397](#1397)) ([f5aff97](f5aff97)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to be able to pass
--label=(i.e. an empty value) to prevent release-please from attempting to add any labels. Currently this doesn't work because javascript thinks""is falsy, and the labels still default toautorelease: pending.