Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add changelog-host input to action.yml #948

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Conversation

eliw00d
Copy link
Contributor

@eliw00d eliw00d commented Feb 27, 2024

This was originally part of 3.3.0 (and fixed in 3.4.1 to default to github.server_url). However, it was not part of 4.0.0.

Without this input, you have to provide both config and manifest files in order to set the changelog-host option.

With this input, you can simply provide release-type and changelog-host without the need for config and manifest files. Also, since it defaults to github.server_url, most users will not even have to set it.

* Update index.ts

Signed-off-by: Paavo Bennett <[email protected]>

* Update index.ts

Signed-off-by: Paavo Bennett <[email protected]>

* Update index.ts

Signed-off-by: Paavo Bennett <[email protected]>

* Update action.yml

Signed-off-by: Paavo Bennett <[email protected]>

* Update index.ts

Signed-off-by: Paavo Bennett <[email protected]>

---------

Signed-off-by: Paavo Bennett <[email protected]>
Copy link

google-cla bot commented Feb 27, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@dtanner
Copy link

dtanner commented Feb 27, 2024

➕ this would be awesome to have - our tens of thousands of repos on GHES now require additional configuration.

@chingor13 chingor13 merged commit 863b06f into googleapis:main Mar 11, 2024
4 checks passed
chingor13 added a commit that referenced this pull request Mar 11, 2024
🤖 I have created a release *beep* *boop*
---


##
[4.1.0](google-github-actions/release-please-action@v4.0.3...v4.1.0)
(2024-03-11)


### Features

* add `changelog-host` input to `action.yml`
([#948](https://github.com/google-github-actions/release-please-action/issues/948))
([863b06f](google-github-actions/release-please-action@863b06f))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: Jeff Ching <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants