Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: read github api/graphql url from action context #532

Merged
merged 4 commits into from
Aug 10, 2022

Conversation

goatwu1993
Copy link
Contributor

Fix #508

This allowed GitHub Enterprise users to use this action without specifying github-api-url and github-graphql-url

@google-cla
Copy link

google-cla bot commented Jul 19, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@goatwu1993 goatwu1993 force-pushed the ci/try-to-use-github-context branch from f57c785 to 420ee2d Compare July 19, 2022 04:02
@goatwu1993 goatwu1993 changed the title feat: release-please-action now read GitHub action context. feat: read github api/graphql url from action context Jul 19, 2022
@goatwu1993
Copy link
Contributor Author

Works on my site.

@goatwu1993
Copy link
Contributor Author

@chingor13 please take a look.

Copy link
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, except the tests are failing.

Looks like core.getInput() returns undefined if not set

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Action should be able to read url from context as default value
2 participants