fix(release-please): update github-release call to new function #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes the wrong call to createRelease now named as run. Tests are also updated.
bcoe
approved these changes
Feb 14, 2021
|
@pragmaticivan thank you for the fix, I should have caught this in review too. Thank you for the contributions. |
This was referenced Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[URGENT] - @v2 is currently broken.
This PR fixes the wrong call to createRelease now named as run.
Tests are also updated.
@bcoe This uses
.run. Really sorry about that.Can't believe I missed that. Paid too much attention to the class change but didn't see
.runwas also a breaking change. Mostly because the project uses Javascript and didn't "warn" me at all.I also did some naming cleaning to make it easier on expect understanding.