Assert fails with duplicate AckRequests #661
Labels
api: pubsub
Issues related to the googleapis/python-pubsub API.
priority: p2
Moderately-important priority. Fix may not be included in next release.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Steps to reproduce
This assertion fails when ack duplication occurs:
python-pubsub/google/cloud/pubsub_v1/subscriber/_protocol/streaming_pull_manager.py
Line 588 in 20d661c
There is no de-duplication of acks in the dispatcher, and because ack_reqs_dict is a Dict[str, AckRequest], the latest AckRequest will replace an earlier request.
The solution is either to change ack_req_dict to allow for multiple AckRequests for the same message, or to de-duplicate acks in the dispatcher.
The text was updated successfully, but these errors were encountered: