Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix flaky test #1254

Merged
merged 1 commit into from
Sep 17, 2024
Merged

fix: Fix flaky test #1254

merged 1 commit into from
Sep 17, 2024

Conversation

mukund-ananthu
Copy link
Contributor

  • OpenTelemetry does not support export of unended spans. This causes flakiness when spans that close async are present.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@mukund-ananthu mukund-ananthu requested review from a team as code owners September 17, 2024 18:56
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Sep 17, 2024
Copy link

conventional-commit-lint-gcf bot commented Sep 17, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Sep 17, 2024
@mukund-ananthu
Copy link
Contributor Author

@parthea PTAL

@mukund-ananthu mukund-ananthu force-pushed the ff branch 5 times, most recently from 7ab077d to 5ea85e7 Compare September 17, 2024 19:21
* OpenTelemetry does not support export of unended spans. This causes
  flakiness when spans that close async are present.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants