Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Use StructuredLogHandler for Cloud Run Job #898

Merged
merged 9 commits into from
Jul 30, 2024

Conversation

gkevinzheng
Copy link
Contributor

  • Moved resource type constants into _monitored_resources.py
  • Return a StructuredLogHandler for the Cloud Run Job environment

Fixes #890

@gkevinzheng gkevinzheng requested review from a team as code owners May 23, 2024 18:54
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: logging Issues related to the googleapis/python-logging API. labels May 23, 2024
@gkevinzheng gkevinzheng deleted the cloud-run-structured-log branch May 23, 2024 19:15
@gkevinzheng gkevinzheng restored the cloud-run-structured-log branch May 23, 2024 19:15
@gkevinzheng gkevinzheng reopened this May 23, 2024
@gkevinzheng gkevinzheng changed the base branch from main to experimental-v4 May 23, 2024 19:17
@product-auto-label product-auto-label bot added the stale: old Pull request is old and needs attention. label Jun 23, 2024
@product-auto-label product-auto-label bot added stale: extraold Pull request is critically old and needs prioritization. and removed stale: old Pull request is old and needs attention. labels Jul 23, 2024
gkevinzheng and others added 4 commits July 29, 2024 18:33
* fix: Added missing import into logger.py (#896)

* test: Fixed unsupported resource type in system test (#904)

* fix: Added type hints to CloudLoggingHandler constructor (#903)

* fix: Added type hints to CloudLoggingHandler constructor

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Removed Client typing due to circular imports

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
…Handler (#908)

* feat!: Use StructuredLogHandler on App Engine instead of
CloudLoggingHandler

* linting
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Jul 29, 2024
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: m Pull request size is medium. labels Jul 29, 2024
@gkevinzheng gkevinzheng added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jul 29, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 29, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 29, 2024
@gkevinzheng gkevinzheng added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 29, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 29, 2024
@gkevinzheng gkevinzheng merged commit 758d439 into experimental-v4 Jul 30, 2024
15 checks passed
@gkevinzheng gkevinzheng deleted the cloud-run-structured-log branch July 30, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the googleapis/python-logging API. size: s Pull request size is small. stale: extraold Pull request is critically old and needs prioritization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Let Cloud Run Job use StructuredLogHandler instead of ClougLoggingHandler
4 participants