Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(python): Add Python 3.12 #203

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Nov 23, 2023

Source-Link: googleapis/synthtool@af16e6d
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:bacc3af03bff793a03add584537b36b5644342931ad989e3ba1171d3bd5399f5

BEGIN_COMMIT_OVERRIDE
feat: add support for Python 3.12
END_COMMIT_OVERRIDE

Source-Link: googleapis/synthtool@af16e6d
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:bacc3af03bff793a03add584537b36b5644342931ad989e3ba1171d3bd5399f5
@gcf-owl-bot gcf-owl-bot bot requested review from a team as code owners November 23, 2023 18:21
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 23, 2023
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Nov 23, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 23, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 23, 2023
@parthea parthea requested a review from a team as a code owner November 24, 2023 18:15
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 24, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 24, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 24, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 24, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 24, 2023
@parthea
Copy link
Collaborator

parthea commented Nov 24, 2023

Wait for cl/585116344

@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 24, 2023
@holtskinner holtskinner added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 27, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 27, 2023
@holtskinner
Copy link
Member

Looks like a module removed in 3.12 is used by the hocr_spec dependency. It's only used in Testing, not the actual library.

https://docs.python.org/3.11/library/imp.html

_________________ ERROR collecting tests/unit/test_document.py _________________
ImportError while importing test module '/home/runner/work/python-documentai-toolbox/python-documentai-toolbox/tests/unit/test_document.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/opt/hostedtoolcache/Python/3.12.0/x64/lib/python3.12/importlib/__init__.py:90: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/unit/test_document.py:36: in <module>
    from hocr_spec import HocrValidator
.nox/unit-3-12/lib/python3.12/site-packages/hocr_spec/__init__.py:6: in <module>
    from .spec import HocrSpec
.nox/unit-3-12/lib/python3.12/site-packages/hocr_spec/spec.py:3: in <module>
    from future import standard_library
.nox/unit-3-12/lib/python3.12/site-packages/future/standard_library/__init__.py:65: in <module>
    import imp
E   ModuleNotFoundError: No module named 'imp'

@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 27, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 27, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 27, 2023
@holtskinner holtskinner merged commit 1ff4bf7 into main Nov 27, 2023
@holtskinner holtskinner deleted the owl-bot-update-lock-bacc3af03bff793a03add584537b36b5644342931ad989e3ba1171d3bd5399f5 branch November 27, 2023 19:42
@parthea parthea added the release-please:force-run To run release-please label Nov 29, 2023
@release-please release-please bot removed the release-please:force-run To run release-please label Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
owl-bot-update-lock size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants