Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v3: remove _convert_retry_deadline helper #858

Closed
daniel-sanche opened this issue Aug 17, 2023 · 0 comments
Closed

v3: remove _convert_retry_deadline helper #858

daniel-sanche opened this issue Aug 17, 2023 · 0 comments
Assignees
@daniel-sanche
Labels
api: bigtable Issues related to the googleapis/python-bigtable API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Milestone
v3-post GA

Comments

@daniel-sanche
Copy link
Contributor

_convert_retry_deadline was used to convert operation failures into properly formatted RetryExceptionGroups. With the addition of the exception_factory argument to streaming retries, we should be able to more cleanly handle this logic with a callback
@daniel-sanche daniel-sanche added type: cleanup An internal cleanup or hygiene concern. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Aug 17, 2023
@daniel-sanche daniel-sanche added this to the v3-beta milestone Aug 17, 2023
@daniel-sanche daniel-sanche self-assigned this Aug 17, 2023
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/python-bigtable API. label Aug 17, 2023
@daniel-sanche daniel-sanche modified the milestones: v3-beta, v3-alpha-2 Sep 18, 2023
@daniel-sanche daniel-sanche modified the milestones: v3-alpha-2, v3-beta Sep 27, 2023
@daniel-sanche daniel-sanche mentioned this issue Dec 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daniel-sanche daniel-sanche

Labels
api: bigtable Issues related to the googleapis/python-bigtable API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
v3-post GA
Development

No branches or pull requests
1 participant
@daniel-sanche